Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten display of iPledge/Isotretinoin form's required fields #70

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

jtquach1
Copy link
Contributor

@jtquach1 jtquach1 commented Jan 19, 2024

Describe your changes

Please include a summary of the changes and the related issue/task. Please also include relevant motivation and context. List any dependencies that are required for this change, including links to other pull requests/branches in other repositories if applicable.

I moved the required fields' text into chips (so each field is legible and not in a paragraph), put the chips into an expandable/retractable accordion, adjusted the spacing of the "Form Loaded" status text, the 3 buttons, and the accordion, and turned ternaries that weren't rendering anything in the falsy condition into boolean expressions.

Before

image

After

image
image

Issue ticket number and Jira link

Please include the Jira Ticket Number and Link for this issue/task.

https://jira.mitre.org/browse/REMS-554

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@plarocque4 plarocque4 self-assigned this Jan 22, 2024
@plarocque4
Copy link
Contributor

This works great, I like how the output is hidden as there is much less space taken up. When you expand the errors the list still seems a little cluttered. I like how things are circled but doing it in red makes it seem busier. Maybe if they are just circled with a subtle background color like gray instead of a hard red line?

@jtquach1
Copy link
Contributor Author

This works great, I like how the output is hidden as there is much less space taken up. When you expand the errors the list still seems a little cluttered. I like how things are circled but doing it in red makes it seem busier. Maybe if they are just circled with a subtle background color like gray instead of a hard red line?

Done

image

@jtquach1 jtquach1 requested a review from plarocque4 January 25, 2024 16:11
@plarocque4 plarocque4 merged commit 7a78554 into dev Jan 26, 2024
3 checks passed
@jtquach1 jtquach1 deleted the rems-554-shorten-ipledge-form-required-fields branch January 26, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants